From: Stefan Huber <shuber2@gmx.at>
Date: Tue, 15 May 2012 10:06:22 +0000 (+0200)
Subject: tarp's output: clean up code
X-Git-Tag: v1.0~4
X-Git-Url: https://git.sthu.org/?p=sitarba.git;a=commitdiff_plain;h=570c75b02f2ed72f43e1cb5246f497165fe2aff6

tarp's output: clean up code
---

diff --git a/shbackup b/shbackup
index 977fb5c..a45305e 100755
--- a/shbackup
+++ b/shbackup
@@ -286,28 +286,14 @@ class BackupManager:
             fl = fcntl.fcntl(fd, fcntl.F_GETFL)
             fcntl.fcntl(fd, fcntl.F_SETFL, fl | os.O_NONBLOCK)
 
-        def readlineNonBlocking(stream):
-            """Read a line nonblocking. Returns b'' if nothing read."""
-            try:
-                return stream.readline()
-            except:
-                return b''
-                pass
-
-
         # Read stdout and stderr of tarp
         errmsg = b""
         while tarp.poll() == None:
             rd,wr,ex = select.select([tarp.stdout, tarp.stderr], [], [], 0.05)
-
             if tarp.stdout in rd:
-                l = readlineNonBlocking(tarp.stdout)
-                if l != b"":
-                    logging.debug(l[:-1].decode())
-
+                logging.debug( tarp.stdout.readline()[:-1].decode() )
             if tarp.stderr in rd:
-                errmsg += readlineNonBlocking(tarp.stderr)
-
+                errmsg += tarp.stderr.read()
 
         # Get the remainging output of tarp
         for l in tarp.stdout.readlines():