From: Stefan Huber <shuber2@gmx.at>
Date: Mon, 14 May 2012 06:53:02 +0000 (+0200)
Subject: enable output of tar
X-Git-Tag: v1.0~13
X-Git-Url: https://git.sthu.org/?p=sitarba.git;a=commitdiff_plain;h=537b4b255e502011b7338c676fe2e64de4c74446;hp=07fa9c2763775fe326e5aec08f8f4ee570072f5b

enable output of tar
---

diff --git a/TODO.txt b/TODO.txt
index f5f0b2c..2488c32 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -1 +1,4 @@
-- support sporadic full backups
+- print size in list
+- remember tar commands
+- ask to proceed when making backup
+- print and log exit code and stderr of tar afterwards
diff --git a/shbackup b/shbackup
index cc323c5..db2c661 100755
--- a/shbackup
+++ b/shbackup
@@ -248,28 +248,12 @@ class BackupManager:
             taropts += ["--exclude", pat]
 
         tarargs = [tarpath] + taropts + ["-f", fsfn] + fileset.dirs
-        print("tarargs: ", tarargs)
-        tarp = subprocess.Popen( tarargs, \
-                stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-
-        while tarp.poll():
-            l = tarp.stdout.readline()
-            if len(l) > 0:
-                print(l.decode(), end="")
-            l = tarp.stderr.readline()
-            if len(l) > 0:
-                print(l.decode(), end="")
-
-        for l in tarp.stdout.readlines():
-            print(l.decode(), end="")
-
-        for l in tarp.stderr.readlines():
-            print(l.decode(), end="")
+        #print("tarargs: ", tarargs)
+        tarp = subprocess.Popen( tarargs )
 
         rett = tarp.wait()
         if rett != 0:
             print(tarpath + " returned with exit status " + str(rett) + ":")
-            print( tarp.stderr.read().decode() )
 
 
     def backup(self, epoch=None, mode=None):