Fix typo, fix next/return/undefined bug with send_mail

[pgp-tools.git] / caff / caff

diff --git a/caff/caff b/caff/caff
index ae922cd96d2f2e7020ba7f1bfe69f0740a8d0d0c..791021aedcccb5ceeb221c8297f3f390aed56711 100755 (executable)
--- a/caff/caff
+++ b/caff/caff
@@ -477,6 +477,9 @@ sub load_config() {
        unless (defined $CONFIG{'mail-template'}) {
                $CONFIG{'mail-template'} .= $_ foreach <DATA>;
        }
+       if ((defined $CONFIG{'also-encrypt-to'}) && ! (ref($CONFIG{'also-encrypt-to'}) eq 'ARRAY')) {
+               $CONFIG{'also-encrypt-to'} = [ $CONFIG{'also-encrypt-to'} ];
+       };
 };
 
 sub make_gpg_fds() {
@@ -766,19 +769,23 @@ sub send_mail($$$@) {
                my ($inputfd, $stdoutfd, $stderrfd, $statusfd, $handles) = make_gpg_fds();
                $gpg->options->push_recipients( $key_id );
                if (defined $CONFIG{'also-encrypt-to'}) {
-                       if (ref($CONFIG{'also-encrypt-to'})) {
-                               $gpg->options->push_recipients($_)
-                                       foreach @{$CONFIG{'also-encrypt-to'}};
-                       } else {
-                               $gpg->options->push_recipients($CONFIG{'also-encrypt-to'});
-                       }
+                       $gpg->options->push_recipients($_) foreach @{$CONFIG{'also-encrypt-to'}};
                }
                my $pid = $gpg->encrypt(handles => $handles);
                my ($stdout, $stderr, $status) = readwrite_gpg($message, $inputfd, $stdoutfd, $stderrfd, $statusfd);
                waitpid $pid, 0;
                if ($stdout eq '') {
-                       warn ("No data from gpg for list-key $key_id\n");
-                       next;
+                       if (($status =~ /^\[GNUPG:\] INV_RECP ([0-9]+) ([0-9A-F]+)/m) and
+                           (defined $CONFIG{'also-encrypt-to'})) {
+                               my $reason = $1;
+                               my $keyid = $2;
+                               if (grep { %_ eq $keyid } @{$CONFIG{'also-encrypt-to'}}) {
+                                       warn("Could not encrypt to $keyid, specified in CONFIG{'also-encrypt-to'}.  Try to update the key using gpg --homedir=\$HOME/caff/gnupghome --import <exported key>.");
+                                       return;
+                               };
+                       };
+                       warn ("No data from gpg for encrypting mail.  STDERR was:\n$stderr\nstatus output was:\n$status\n");
+                       return;
                };
                $message = $stdout;
 
@@ -1308,12 +1315,15 @@ for my $keyid (@keyids_ok) {
                                $address =~ s/.*<(.*)>.*/$1/;
                                if (ask("Mail signature for $uid->{'text'} to '$address'?", 1, $CONFIG{'mail'})) {
                                        my $mail = send_mail($address, $can_encrypt, $longkeyid, $uid, @attached);
-
-                                       my $keydir = "$KEYSBASE/$DATE_STRING";
-                                       my $mailfile = "$keydir/$longkeyid.mail.".$uid->{'serial'}.".".sanitize_uid($uid->{'text'});
-                                       open (KEY, ">$mailfile") or die ("Cannot open $mailfile: $!\n");
-                                       print KEY $mail;
-                                       close KEY;
+                                       if (defined $mail) {
+                                               my $keydir = "$KEYSBASE/$DATE_STRING";
+                                               my $mailfile = "$keydir/$longkeyid.mail.".$uid->{'serial'}.".".sanitize_uid($uid->{'text'});
+                                               open (KEY, ">$mailfile") or die ("Cannot open $mailfile: $!\n");
+                                               print KEY $mail;
+                                               close KEY;
+                                       } else {
+                                               warn "Generating mail failed.\n";
+                                       };
                                };
                        };
                };